minor fixes and 64-bit support #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this looks fine. the reason the constant in the .pch file might not be working is because the .pch file might not be specified as the prefix header in the build settings. i've seen this error, along with the wrapper extension being the default (.bundle), in a lot of plugins. i think it has to do with some settings not being imported from the Xcode 3 projects into Xcode 4 properly. but if the plugin builds, then whether it looks at the .pch file or not doesn't really matter. |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, I’ve just been updating plug-ins so they’ll build as 32/64-bit without pull requests. (@neurolepsy and I discussed it first.)
This one required some small changes before it would compile, so I figure someone else should take a look before it gets pushed to the main repo.